[PATCH] tls: Fix warning Wunused-variable

Lukas Slebodnik lslebodn at redhat.com
Sat Sep 17 20:09:16 UTC 2016


ehlo,

simple patch is attached.

LS
-------------- next part --------------
From d9f10ce81814c36f2c48247d607d3afa4ff1dbfb Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Sat, 17 Sep 2016 18:03:12 +0200
Subject: [PATCH] tls: Fix warning Wunused-variable
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The variable error_pos is used only with enabled ENABLE_GNUTLS
There are warnings if compiled witout gnutls

../source4/lib/tls/tls_tstream.c: In function ‘_tstream_tls_connect_send’:
../source4/lib/tls/tls_tstream.c:1053:14:
    warning: unused variable ‘error_pos’ [-Wunused-variable]
  const char *error_pos;
              ^~~~~~~~~
../source4/lib/tls/tls_tstream.c: In function ‘_tstream_tls_accept_send’:
../source4/lib/tls/tls_tstream.c:1333:14:
     warning: unused variable ‘error_pos’ [-Wunused-variable]
  const char *error_pos;
              ^~~~~~~~~

Signed-off-by: Lukas Slebodnik <lslebodn at redhat.com>
---
 source4/lib/tls/tls_tstream.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source4/lib/tls/tls_tstream.c b/source4/lib/tls/tls_tstream.c
index 5045e88eec6109dd300040ff5d37ea8daa109ea2..28fe3328b124ba5844377497bb50532e45880852 100644
--- a/source4/lib/tls/tls_tstream.c
+++ b/source4/lib/tls/tls_tstream.c
@@ -1050,8 +1050,8 @@ struct tevent_req *_tstream_tls_connect_send(TALLOC_CTX *mem_ctx,
 {
 	struct tevent_req *req;
 	struct tstream_tls_connect_state *state;
-	const char *error_pos;
 #if ENABLE_GNUTLS
+	const char *error_pos;
 	struct tstream_tls *tlss;
 	int ret;
 #endif /* ENABLE_GNUTLS */
@@ -1330,8 +1330,8 @@ struct tevent_req *_tstream_tls_accept_send(TALLOC_CTX *mem_ctx,
 	struct tevent_req *req;
 	struct tstream_tls_accept_state *state;
 	struct tstream_tls *tlss;
-	const char *error_pos;
 #if ENABLE_GNUTLS
+	const char *error_pos;
 	int ret;
 #endif /* ENABLE_GNUTLS */
 
-- 
2.9.3



More information about the samba-technical mailing list