[PATCH] Cache messaging dgm connections

[Jeremy Allison]

On Sat, Sep 17, 2016 at 06:55:47PM +0200, Andreas Schneider wrote:
> On Saturday, 17 September 2016 07:42:34 CEST Jeremy Allison wrote:
> > On Sat, Sep 17, 2016 at 01:17:55PM +0200, Andreas Schneider wrote:
> > > On Friday, 16 September 2016 14:03:42 CEST Jeremy Allison wrote:
> > > > Still got the crash with this in autobuild, now with the backtrace
> > > > below. So we're still not catching everything (or something else
> > > > is freeing ev behind our backs :-).
> > > > 
> > > > As I know we're going to be co-located on Monday, let's
> > > > schedule a time to look at this directly at the SNIA
> > > > conf.
> > > 
> > > This looks like a bug report in Fedora with Samba 4.5.0. smbd directly
> > > segfaults at startup!
> > > 
> > > Backtrace and core file is attached to the bug. We have this since rc1.
> > > 
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1375973
> > 
> > With the latest patch I posted it passed a private
> > autobuild.
> > 
> > I'm trying again a few times today but I'm hopeful
> > I've found it.
> > 
> > The bug with selecting the right slot to replace
> > could have lead to two contexts with the same tevent_context
> > being in the array at the same time, which might
> > explain the problems we've been seeing.
> > 
> > I'll report back after a couple more private autobuilds..
> 
> Could you please open a bug and add the bug url to the patchset please!

It seems to be reliably passing, but I want to do one
more successful private autobuild before proposing to
push.

I'll update the patchset commit comments with a bugid before re-posting
to the list for review. We already have positive review
for the first 3 patches (Ralph and I) so I'll just need
a +1 on the last patch (the correct slot selection) to
push. IMHO it's a pretty obvious bugfix once you spot
the problem.

Cheers,

Jeremy.