[PATCH] Cache messaging dgm connections

Jeremy Allison jra at samba.org
Fri Sep 16 15:36:33 UTC 2016


On Fri, Sep 16, 2016 at 11:29:06AM +0200, Ralph Böhme wrote:
> On Thu, Sep 15, 2016 at 10:09:18AM -0700, Jeremy Allison wrote:
> > On Thu, Sep 15, 2016 at 06:38:25PM +0200, Ralph Böhme wrote:
> > > 
> > > I got one through with these two patches. Running more...
> > > 
> > > Cheerio!
> > 
> > Oh, this looks more elegant than the reparent struct poll_funcs_tevent_context
> > to ev patch I just posted...
> > 
> > The:
> > 
> >  +     TALLOC_FREE(msg->msg_dgm_ref);
> > 
> > looks very clever :-).
> 
> it passed three more autobuilds. Shall we push it?

Yes please - the version we discussed on the phone
with the free of the timer events followed by context,
plus the TALLOC_FREE(msg->msg_dgm_ref); change !

Reviewed-by: Jeremy Allison <jra at samba.org>

I think this might fix a whole host of previously
unknown crash bugs !



More information about the samba-technical mailing list