[PATCH] tevent docu fixes
Jeremy Allison
jra at samba.org
Thu Sep 15 23:29:30 UTC 2016
On Mon, Sep 12, 2016 at 04:57:46PM +0200, Volker Lendecke wrote:
> On Mon, Sep 12, 2016 at 03:29:27PM +0100, Rowland Penny wrote:
> > On Mon, 12 Sep 2016 15:54:53 +0200
> > Volker Lendecke <vl at samba.org> wrote:
> >
> > > Hi!
> > >
> > > Review appreciated!
> > >
> > > Thanks, Volker
> > >
> > > P.S: When they go through, how do we upload them to tevent.samba.org??
> >
> > Just one problem Volker, the first one is in terrible English, before
> > your suggested patch, could I suggest:
> >
> > Both functions accept just one parameter (tevent context) and the only
> > difference lies in the fact that the first loop can theoretically last for ever,
> > but the second will wait for just a single event to catch and then break the
> > loop and allow the program to continue.
>
> From my point of view the whole tutorial could benefit from a native
> speaker looking over it. The problem is that git is not made for plain
> text, patches will rewrite the whole thing. So I left it as is and
> just fixed the obvious typo.
Let's go over it in the next 2 weeks sometime as we'll be working
together anyway.
More information about the samba-technical
mailing list