[PATCH] Fix bug 12268

Volker Lendecke vl at samba.org
Thu Sep 15 14:07:04 UTC 2016


On Thu, Sep 15, 2016 at 09:25:14AM -0400, Simo wrote:
> On Thu, 2016-09-15 at 13:57 +0200, Volker Lendecke wrote:
> > Review appreciated!
> 
> Is this file descriptor being accessed in a separate thread then ?
> Or does a read() on it risk blocking the whole smbd ?

That's our standard aio way of doing things. With aio, it's in a
thread, without aio, it's blocking smbd. If you look at the pread
susv4 definition, ETIMEDOUT is not defined as an error condition, so
you might argue that it's GPFS's fault. But I thought as this might
also happen in other situations, I put it into main smbd. If you think
it's better done in vfs_gpfs, I can also put it there.

Volker



More information about the samba-technical mailing list