[PATCH] Cache messaging dgm connections

Jeremy Allison jra at samba.org
Wed Sep 14 23:56:26 UTC 2016


On Thu, Sep 15, 2016 at 11:36:55AM +1200, Garming Sam wrote:
> Hi Ralph,
> 
> Seen some flapping tests in autobuild, and it looks like it's related to
> the dgram changes. I originally thought it was another replication
> issue, because of an IO timeout, but apparently not.
> 
> I'm not sure if it's the callers fault here, but I thought it would be
> easier if you could take a look and give some advice.
> 
> https://git.samba.org/autobuild.flakey.sn-devel-144/2016-09-14-1112/samba.stderr
> 
> 
> Cheers,
> 
> Garming

Garming, is this before or after the fixes to that
patchset that went in today ?

These were:

commit e62ff6c41da328ffd1948f128877ec4b8582fe45
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Sep 14 07:16:26 2016 +0200

    unix_msg: Fix unix_dgram_send_queue_init
    
    We should not free a DLIST element
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Wed Sep 14 19:30:28 CEST 2016 on sn-devel-144

commit 5f764be23d46194a63c81fa6743e555eebce1458
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Sep 14 07:13:38 2016 +0200

    unix_msg: Fix CID 1372875 Double close
    
    The two error callers of unix_dgram_sendq_schedule_free already run down the
    sendq in the error case.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>





More information about the samba-technical mailing list