Samba In-Tree Heimdal

[Stefan Metzmacher]

Am 14.09.2016 um 20:50 schrieb Andrew Bartlett:
> On Wed, 2016-09-14 at 10:47 -0700, Jeremy Allison wrote:
>> On Wed, Sep 14, 2016 at 07:15:06PM +0200, Andreas Schneider wrote:
>>>
>>> Hello,
>>>
>>> I'm currently cleaning up cliconnect.c and wanted to correctly
>>> implement the 
>>> kinit for librpc/crypto/gse.c. Checking if the tickets is already
>>> in the 
>>> ccache, make sure it isn't expired else get it and store the ticket
>>> in the 
>>> ccache ...
>>>
>>>
>>> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/mast
>>> er-libsmb
>>>
>>>
>>> However, this fails because of:
>>>
>>> ../source3/librpc/crypto/gse.c:312: error: undefined reference to 
>>> 'gss_acquire_cred_with_password'
>>> ../source3/librpc/crypto/gse.c:330: error: undefined reference to 
>>> 'gss_store_cred'
>>>
>>> Luke Howard implemented support for that in 2011:
>>>
>>> https://github.com/heimdal/heimdal/commit/
>>> 02cf28e20b852caffdb77e008f6bb6c4c0ead532
>>>
>>>
>>> Is our Heimdal really out of sync more than five years?
>>
>> It appears so :-(.
> 
> Yes.
> 
>>>
>>> Are there any plans to get a newer version or remove it from the
>>> tree?
> 
> Various folks have attempted an update.  Some of us work on that when
> we have time.  Otherwise, we are essentially waiting on your work to
> give us another path out of this mire.
> 
> I have dreams of one last update (to give us a reasonable fallback for
> the MIT switch that isn't 6 years old at that point), but they are just
> dreams. :-(
> 
>> Oh that's sad - the header references to these are there, but not the
>> implementations.
> 
> One important point:  We tried not to copy all of heimdal in, so if you
> are just missing the file, that is fairly easy to fix, just copy that
> file in from the last version.  I'll see if I can help with that. 

git log --oneline source4/heimdal/lib/gssapi/gssapi/gssapi.h

5a8635b s4:heimdal: import lorikeet-heimdal-201107241840 (commit
0fdf11fa3cdb47df9f5393ebf36d9f5742243036)
255e3e1 s4:heimdal: import lorikeet-heimdal-201107150856 (commit
48936803fae4a2fb362c79365d31f420c917b85b)

From there:

git grep gss_acquire_cred_with_password
0fdf11fa3cdb47df9f5393ebf36d9f5742243036
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:appl/test/gssapi_client.c:
  maj_stat = gss_acquire_cred_with_password(&min_stat,
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/Makefile.am:
mech/gss_acquire_cred_with_password.c \
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/NTMakefile:
mech/gss_acquire_cred_with_password.c \
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/NTMakefile:
$(OBJ)\mech/gss_acquire_cred_with_password.obj \
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/gssapi/gssapi.h:GSSAPI_LIB_FUNCTION
OM_uint32 GSSAPI_LIB_CALL gss_acquire_cred_with_password
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/libgssapi-exports.def:
     gss_acquire_cred_with_password
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/mech/compat.h:typedef
OM_uint32 GSSAPI_CALLCONV _gss_acquire_cred_with_password_t
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/mech/compat.h:
_gss_acquire_cred_with_password_t   *gmc_acquire_cred_with_password;
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/mech/gss_acquire_cred_with_password.c:gss_acquire_cred_with_password(OM_uint32
*minor_status,
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/test_context.c:
maj_stat = gss_acquire_cred_with_password(&min_stat,
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/test_context.c:
   errx(1, "gss_acquire_cred_with_password: %s",
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/version-script.map:
       gss_acquire_cred_with_password;

git show
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/mech/gss_acquire_cred_with_password.c
>
  source4/heimdal/lib/gssapi/mech/gss_acquire_cred_with_password.c

is what you need.

The same applies to
0fdf11fa3cdb47df9f5393ebf36d9f5742243036:lib/gssapi/mech/gss_store_cred.c

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160915/2a3e639c/signature.sig>