Request for review of Samba VirusFilter preparation for merging with Samba

[Trever L. Adams]

Sorry, the URL is
https://github.com/treveradams/samba-virusfilter/tree/virusfilter-merge
for the merged branch.

On 09/14/2016 05:13 PM, Trever L. Adams wrote:
> I have applied that patch and have things compiling and working. Not
> everything may be as would be preferred and I am open to suggestions.
> The timeout is currently per poll/write. I can make it per call using
> time_mono if that is desired. It seems to be extra overhead with little
> win for the use case here, but it may not be for future users of the
> same functions.
>
> The changes to example directory need to be reviewed as well. I still
> would like feed back on the following questions:
>
> 2) in virusfilter_vfs_close with a parameter files_struct *fsp,
> SMB_VFS_NEXT_CLOSE is called before local processing. If that returns -1
> with errno EBADF will fsp->modified still be valid?
> 3) The author/maintainer has asked that I move some templates for
> configuration to examples/virusfilter. These have some place holders
> such @SAMBA_CONFIGDIR at . Is this the right place for these files? Should
> I keep such place holders? How do I set things up to process them? If
> not, what should I replace them with?
> 4) The test directory in the top of the the project contains a complete
> directory layout. Any suggestions on how/where to place these?
> (I have moved them, but not modified them.)
>
> Thank you to any and all who have helped and who may yet help in this
> merging process.
>
> Trever
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160914/62bb7795/signature.sig>