Request for review of Samba VirusFilter preparation for merging with Samba

Trever L. Adams trever at middleearth.sapphiresunday.org
Wed Sep 14 23:13:28 UTC 2016


On 09/12/2016 05:53 PM, Trever L. Adams wrote:
>> On 09/12/2016 04:34 PM, Trever L. Adams wrote:
>>> On 09/12/2016 01:16 PM, Trever L. Adams wrote:
>>>> On 09/12/2016 08:25 AM, Volker Lendecke wrote:
>>>>> Don't you want an overall timeout per request? Right now if you have
>>>>> to poll multiple times every time a new timeout is started.
>>>>>
>>>>> Volker
>>>>>
>>> I have been thinking about your suggestion. The only issue I see with it
>>> is that time spent in each poll must be ascertained. Are there fast
>>> functions for getting clock ticks that are reliable on all platforms?
>>>
>>> Trever
>>>
>> Barring the ability and recommendation to do clock checks, I believe I
>> have a solution. It has been tested.
>>
>> I have attached the patch to Samba. My tree currently uses this patch.
>>
>> Trever
I have applied that patch and have things compiling and working. Not
everything may be as would be preferred and I am open to suggestions.
The timeout is currently per poll/write. I can make it per call using
time_mono if that is desired. It seems to be extra overhead with little
win for the use case here, but it may not be for future users of the
same functions.

The changes to example directory need to be reviewed as well. I still
would like feed back on the following questions:

2) in virusfilter_vfs_close with a parameter files_struct *fsp,
SMB_VFS_NEXT_CLOSE is called before local processing. If that returns -1
with errno EBADF will fsp->modified still be valid?
3) The author/maintainer has asked that I move some templates for
configuration to examples/virusfilter. These have some place holders
such @SAMBA_CONFIGDIR at . Is this the right place for these files? Should
I keep such place holders? How do I set things up to process them? If
not, what should I replace them with?
4) The test directory in the top of the the project contains a complete
directory layout. Any suggestions on how/where to place these?
(I have moved them, but not modified them.)

Thank you to any and all who have helped and who may yet help in this
merging process.

Trever

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160914/a1fd1a07/signature.sig>


More information about the samba-technical mailing list