[PATCH] ctdb-protocol: Fix marshalling for GET_DB_SEQNUM control request (bug 12259)
Martin Schwenke
martin at meltin.net
Wed Sep 14 04:20:06 UTC 2016
On Wed, 14 Sep 2016 14:16:46 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:
> On Wed, Sep 14, 2016 at 2:12 PM, Martin Schwenke <martin at meltin.net> wrote:
>
> > On Wed, 14 Sep 2016 12:09:39 +1000, Amitay Isaacs <amitay at gmail.com>
> > wrote:
> >
> > > The new protocol code did not marshal database id for GET_DB_SEQNUM
> > control
> > > correctly.
> > > This creates a problem on big-endian architecture.
> > >
> > > Even though database id is 32-bit, it's sent on wire as 64-bit value.
> > Make
> > > sure it's sent as first 32-bits.
> > >
> > > Please review and push.
> >
> > Can we please add the "Make sure it's sent as first 32-bits" to the
> > commit message? I was looking for a magic cast but you have used a
> > nicer approach... :-)
> Sure. Attached with extra statement.
Double-plus-good Reviewed-by: Martin Schwenke <martin at meltin.net>
:-)
peace & happiness,
martin
More information about the samba-technical
mailing list