[PATCH] Implement a more abstracted kpasswd service

[Andreas Schneider]

On Monday, 12 September 2016 12:22:58 CEST Jeremy Allison wrote:
> On Fri, Sep 09, 2016 at 10:10:52AM +0200, Andreas Schneider wrote:
> > On Thursday, 8 September 2016 15:26:20 CEST Jeremy Allison wrote:
> > > On Wed, Sep 07, 2016 at 06:02:45PM +0200, Andreas Schneider wrote:
> > > > Hi Andrew,
> > > > 
> > > > I've implemented a working kpasswd service with MIT Kerberos in the
> > > > meantime. This patchset is the work to cleanup Heimdal code and
> > > > prepare
> > > > for later MIT Kerberos code.
> > > > 
> > > > I've started with splitting up the test_passwords.sh test. Now we have
> > > > a
> > > > test_password_settings.sh and test_kpasswd_heimdal.sh test.
> > > > 
> > > > The test_kpasswd_heimdal.sh only tests the kpasswd service
> > > > implementation
> > > > in different ways. It has some additional tests, like doing a password
> > > > change with kinit.
> > > > 
> > > > Next I reworked the kpasswd service implementation to be able to share
> > > > code
> > > > which is not Kerberos flavor specific.
> > > > 
> > > > The patchset is attached but you can also find it here:
> > > > 
> > > > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/master-> > > > kpas
> > > > swd
> > > > 
> > > > 
> > > > Please review and push if appropriate!
> > > 
> > > Pushed the first 4 patches as they're obviously correct.
> > > 
> > > Still looking over the rest !
> > 
> > Thanks you very much Jeremy!
> 
> OK, pushed the rest - except the last patch, which is quite
> obviously crazy (it deletes the kdc code :-) and due to you
> fat-fingering the file you really wanted to delete :-).
> 
> Attached is what I *think* you wanted to do - can you confirm ?

Yes, the kpasswd-heimdal.c file is the one which is obsolete.


Thanks,


	-- andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org