[PATCH] fix for bug 10882

[Jeremy Allison]

On Thu, Sep 08, 2016 at 08:36:26PM +0100, Rowland Penny wrote:
> On Thu, 8 Sep 2016 12:27:30 -0700
> Jeremy Allison <jra at samba.org> wrote:
> 
> > On Thu, Sep 08, 2016 at 06:33:44PM +0100, Rowland Penny wrote:
> > > 
> > > I am posting this at Jeremy's request, this Patch along with
> > > Garmin's Patch, fixes the inability to recreate a deleted Bind user
> > > 'dns-*' with samba_upgradedns.
> > > 
> > > It is quite a simple patch, it move the deletion of the users from
> > > the bottom of the script (where they are only deleted if you are
> > > upgrading to the internal dns server and they exist) to midway in
> > > the script before the script portions for 'BIND9_DLZ' and
> > > 'SAMBA_INTERNAL'. It doesn't matter if they are deleted here, this
> > > is because if they are required, they will be created again.
> > > 
> > > This has always worked for me since I wrote it two months ago, it
> > > just didn't work if your AD DC was created with an old version,
> > > Garmin's patch fixes this.
> > > 
> > > Jeremy asked me to post Garmin's patch, but it is already posted
> > > here:
> > > 
> > > https://lists.samba.org/archive/samba-technical/2016-September/116018.html
> > 
> > Rowland, Andreas replied to that saying he'd like to see
> > the saltPrincipal value updated rather than removing the
> > check.
> > 
> > https://lists.samba.org/archive/samba-technical/2016-September/116024.html
> > 
> > So I think Garmin's patch isn't quite right here.
> 
> I have just done a bit of checking here, it was a patch from Andreas
> that added the saltPrincipal, so I think it is wrong to say that
> Garmin's patch isn't right.

What commit refspec was that ? Andreas, can you comment here
so we can get this sorted ?

Cheers,

	Jeremy.