[PATCHES] wider use of torture_comment in some torture tests

Günther Deschner gd at samba.org
Wed Sep 7 10:11:16 UTC 2016


On 06/09/16 21:57, Uri Simchoni wrote:
> On 09/06/2016 06:27 PM, Günther Deschner wrote:
>> Hi,
>>
>> please review and push.
>>
>> Guenther
>>
> 
> It looks like the last hunk in [3/10] belongs in [5/10] - depends on
> torture_smb2_createfile being public. Well, it wasn't getting built so
> maybe that's not so bad...

Yeah, that's right but I left that way.

> 
> Beside the use of torture_comment(), many of the changes are naming
> convention changes, torture->tctx. 8/10 is purely torture->tctx. So
> maybe that needs to be in the commit message.

Ah, correct, in the meantime you changed the smb2 read test to use
standard torture macros/functions already so the core piece of my older
patch has become obsolete. I removed it.

> Other than that, RB+ me.

Great, pushed to autobuild.

Thanks,
Guenther

-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org



More information about the samba-technical mailing list