[WIP] Remove confusing --use-xattrs option from samba-tool domain provision

[Rowland Penny]

On Sun, 04 Sep 2016 22:32:46 +1200
Andrew Bartlett <abartlet at samba.org> wrote:

> We keep it if built with NTVFS support, but it should cause less
> confusion once most users stop seeing it. 
> 
> I realise this may break some scripts, but in this case I think it is
> worth it for the simplification. 
> 
> This isn't for 4.5 (we don't change this kind of thing during an RC),
> but should help simplify things for 4.6, and make it clear to others
> that the default of --use-xattr is and has always been perfectly
> correct. 
> 
> I'm running an autobuild to confirm I haven't broken anything else. 
> 
> Comment welcome.
> 
> Andrew Bartlett

Hi Andrew, there is this in the patch header:

The only reasonable use --use-xattrs=no should be used is in selftest,
and there is no need for that or --use-xattrs=auto without
--use-ntvfs, all systems we support in production for the AD DC have
xattrs, as using smbd needs posix ACLs.

I take it we are no longer supporting UNIX OS's, because from my
testing on Freebsd, you cannot provision an AD DC on that OS, this is
because '--use-ntvfs' has been removed from the options and Freebsd
uses ntvfs4 ACLs.

Can I also ask why, now that we only seem to support OS's that also
support posix ACLs, why we are still using ntvfs, wouldn't this be a
good time to get rid of it. I mean, what is the point of keeping code
around that will never be used except for testing against.

Rowland