[PATCH] Fix the build

Jeremy Allison jra at samba.org
Fri Sep 2 16:02:25 UTC 2016


On Fri, Sep 02, 2016 at 10:06:56AM +0200, Michael Adam wrote:
> 
> 1000 times no!
> 
> We should rather have a check script that validates the patch.
> 
> e.g. glusterfs does this:
> 
> https://github.com/gluster/glusterfs/blob/master/rfc.sh
> 
> which is used to submit patches, calls
> 
> https://github.com/gluster/glusterfs/blob/master/extras/checkpatch.pl
> 
> We could include something similar in our autobuild receive hook
> on the autobuild server. So that patches that don't adhere are
> rejected. (A forceful override can be discussed.)
> 
> It is just too annoying that this is consistently ignored.
> As you explained, there are good reasons beyond cosmetics.

I would prefer this (the reject script). Having this
centrally enforced would concentrate the mind wonderfully.

Yes, I know about the issues with debug messages, but
as someone pointed out they're already often composed
strings for which you can't git grep anyway, so people
are already working around this issue.

Michael, if you want to create a patch to add the
checkpatch to Samba I'd enthusiasticly push it (once
consensus has been reached on email of course :-) :-).



More information about the samba-technical mailing list