[PATCHSET] Cleanup krb5_wrap and other kerberos stuff

Andreas Schneider asn at samba.org
Fri Sep 2 05:41:37 UTC 2016


On Friday, 2 September 2016 06:52:55 CEST Andrew Bartlett wrote:
> On Wed, 2016-08-31 at 08:09 +0200, Andreas Schneider wrote:
> > On Tuesday, 30 August 2016 17:01:11 CEST Andreas Schneider wrote:
> > > On Tuesday, 30 August 2016 15:51:03 CEST Andreas Schneider wrote:
> > > > You can also find the patchset here:
> > > > 
> > > > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/ma
> > > > ster-mit->; > kd c-ok
> > > 
> > > I removed smb_krb5_free_error() because it depends which function
> > > you need
> > > to call. And example is https://git.samba.org/?p=asn/
> > > samba.git;a=commitdiff;h=b2efe9d28b48c589241a4cec16204770c2c467c6
> > > 
> > > Depending on the Kerberos impelementation
> > > krb5_init_creds_get_error() returns an allocated pointer or just
> > > fills a
> > > structure. So the variable needs to be declared and passed
> > > differently.
> > 
> > And too many brackets ... works with MIT Kerberos now.
> 
> Sorry, I didn't see that one at the time I was doing my review work. 

No problem. Thanks for the review!!!

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list