[PATCH] CTDB event script error (and unusual) path fixes (bug 12180)

趙 良基 hijk123452001 at hotmail.com
Thu Sep 1 05:53:19 UTC 2016


Hi,
I use gluster replica 3 volume as CTDB recovery lockfile path,but when split brain happend (split to 2 nodes and 1 node) the 1 node also can open the lockfile so that 1 node can takeover all IPs.

2016/08/31 23:49:22.296820 [set_recmode: 5604]: ctdb_recovery_lock:fd=5 - (No such file or directory)
2016/08/31 23:52:19.963449 [recoverd:26006]: ctdb_recovery_lock:fd=37 - (Cannot assign requested address)

Volume Name: IFTSwiftShareVol
Type: Replicate
Volume ID: 2501be2f-90be-477f-947a-2832198c982c
Status: Started
Number of Bricks: 1 x 3 = 3
Transport-type: tcp
Bricks:
Brick1: CS174119:/export/IFT_lvol_LujgjV35tD/fs
Brick2: CS7dc2b:/export/IFT_lvol_RhVVs85UEk/fs
Brick3: CS81876:/export/IFT_lvol_RgEJJyCnZs/fs
Options Reconfigured:
cluster.quorum-type: auto
cluster.server-quorum-type: server
nfs.disable: on
performance.readdir-ahead: on
cluster.server-quorum-ratio: 51%

-----Original Message-----
From: samba-technical [mailto:samba-technical-bounces at lists.samba.org] On Behalf Of Amitay Isaacs
Sent: Thursday, September 01, 2016 11:18 AM
To: Martin Schwenke <martin at meltin.net>
Cc: Samba Technical <samba-technical at lists.samba.org>
Subject: Re: [PATCH] CTDB event script error (and unusual) path fixes (bug 12180)

On Wed, Aug 31, 2016 at 5:38 PM, Martin Schwenke <martin at meltin.net> wrote:

> There is some bad callback and talloc_steal() logic in the CTDB 
> daemon's event script code that can uninitialised pointers to be dereferenced.
> The attached patches fix the issues and add a test for one obvious case.
>
> Please review and maybe push...
>
> peace & happiness,
> martin
>

Pushed to autobuild.

Amitay.


More information about the samba-technical mailing list