[PATCHSET] Cleanup krb5_wrap and other kerberos stuff

Andrew Bartlett abartlet at samba.org
Thu Sep 1 03:09:09 UTC 2016


On Tue, 2016-08-30 at 17:01 +0200, Andreas Schneider wrote:
> On Tuesday, 30 August 2016 15:51:03 CEST Andreas Schneider wrote:
> > You can also find the patchset here:
> > 
> > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/mast
> > er-mit-kd
> > c-ok
> 
> I removed smb_krb5_free_error() because it depends which function you
> need to 
> call. And example is https://git.samba.org/?p=asn/
> samba.git;a=commitdiff;h=b2efe9d28b48c589241a4cec16204770c2c467c6
> 
> Depending on the Kerberos impelementation 
> krb5_init_creds_get_error() returns an allocated pointer or just
> fills a 
> structure. So the variable needs to be declared and passed
> differently.

Thanks.  I did find the move from 'standard' to Samba's 'sloppy' naming
in the previous patch annoying when I reviewed it, so it is great to
have this cleaned up!

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Pushed!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list