[PATCH] Moving RID manager causes replication issues
abartlet at samba.org
Mon Oct 31 03:42:34 UTC 2016
On Fri, 2016-10-28 at 15:04 +1300, Clive Ferreira wrote:
> This patch relaxes the objectclass_attrs check which requires that
> mandatory attributes are present. If the attribute is mandatory, but
> not replicated (which is limited to only two attributes: rIDNextRid
> rIDPreviousAllocationPool) then we should let the modification
> This change is required for moving the RID manager role and
> to allocate a new RID pool from it. Although this check could be
> by actually setting the value consistently, it doesn't resolve
> databases and the edge case is only for two attributes (used for RID
> allocation). Furthermore, it removes the special case for requiring a
> dbcheck control to avoid errors.
> The new test passes against Windows, but errors out at the cleanup
> where we move back the RID master role to the original DC (which
> be due to a time-delay in transfering roles).
> The second patch was missing a sign-off by Bob, which he can
> approve here.
> Any thoughts would be appreciated.
This looks great! Our users who move RID Manager roles around will
very much appreciate this fix.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical