[Patch] Regression fix for roaming profiles (bug #10297)
jra at samba.org
Tue Oct 25 00:17:05 UTC 2016
On Mon, Oct 24, 2016 at 03:28:31PM -0700, Jeremy Allison wrote:
> On Sat, Oct 22, 2016 at 10:15:08AM +0200, Stefan Metzmacher wrote:
> > Hi,
> > here's a possible regression fix for
> > https://bugzilla.samba.org/show_bug.cgi?id=10297
> > Existing patches were supposed to fix the drop box share
> > (-wx permissions) use case, but they broke the roaming profiles
> > use case.
> > Do we have regression tests for the drop box feature?
> > I was hoping to add tests for roaming profiles, but it's
> > harder than expected, because make test runs as just one
> > real unix user and we won't get EACCES failures there.
> > Please review and test that the drop box feature still
> > works as desired.
> Ah, OK - so the underlying change is to only set
> UCF_PREP_CREATEFILE in the cases where O_CREAT
> would get set in the underlying POSIX call.
> Looks correct to me, but I'll check he
> dropbox case before pushing.
Yep - dropbox case works. Looking at the bug report,
turns out the reporter also had:
unix extensions = no
wide links = yes
set, which confused the issue (meant I didn't spot
the FILE_OPEN request should return NT_STATUS_ACCESS_DENIED).
Thanks for the fix - pushed !
More information about the samba-technical