[PATCH] Stop streams_depot from leaving lost-XXXX directories on file deletion.

Jeremy Allison jra at samba.org
Thu Oct 20 20:39:37 UTC 2016

On Thu, Oct 20, 2016 at 09:00:04AM -0700, Jeremy Allison wrote:
> On Thu, Oct 20, 2016 at 07:27:52AM +0300, Uri Simchoni wrote:
> > On 10/20/2016 02:53 AM, Jeremy Allison wrote:
> > > +    echo "$out" >>/tmp/lookatme
> > You want to keep this?
> Oh no ! Thanks for spotting that (was a side effect
> getting the tests to work :-).
> > Otherwise RB+ me.
> Thanks a *LOT* for catching that !

Uri - turns out we need this additional
patch before the reviewed patchset. Otherwise
the vfstest stream-depot test breaks
(it does:

mkdir x
open x:y RC 0770
unlink x:y
rmdir x

) and the unlink x:y fails when vfstest
isn't stream aware. The previous bug was
masking this problem I think.

Can you review ? Then I can push all 3
(minus the echo "$out" >>/tmp/lookatme of course :-).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-torture-vfstest.-unlink-cmd-must-be-stream-aware.patch
Type: text/x-diff
Size: 1228 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161020/4997d922/0002-s3-torture-vfstest.-unlink-cmd-must-be-stream-aware.diff>

More information about the samba-technical mailing list