[PATCH] Two small ones

[Jeremy Allison]

On Thu, Oct 13, 2016 at 04:10:37PM +0200, Volker Lendecke wrote:
> Hi!
> 
> Review appreciated!

LGTM - pushed !

> From 241a9c20a374479e968a403e53a0acafc2f92e5d Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Thu, 13 Oct 2016 11:18:50 +0200
> Subject: [PATCH 1/2] debug: Fix a few signed/unsigned hickups
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  lib/util/debug.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/util/debug.c b/lib/util/debug.c
> index ed89944..625d23a 100644
> --- a/lib/util/debug.c
> +++ b/lib/util/debug.c
> @@ -280,7 +280,7 @@ static struct debug_backend {
>  
>  static struct debug_backend *debug_find_backend(const char *name)
>  {
> -	int i;
> +	unsigned i;
>  
>  	for (i = 0; i < ARRAY_SIZE(debug_backends); i++) {
>  		if (strcmp(name, debug_backends[i].name) == 0) {
> @@ -348,7 +348,7 @@ static void debug_set_backends(const char *param)
>  	size_t str_len = strlen(param);
>  	char str[str_len+1];
>  	char *tok, *saveptr;
> -	int i;
> +	unsigned i;
>  
>  	/*
>  	 * initialize new_log_level to detect backends that have been
> @@ -389,7 +389,8 @@ static void debug_set_backends(const char *param)
>  static void debug_backends_log(const char *msg, int msg_level)
>  {
>  	char msg_no_nl[FORMAT_BUFR_SIZE];
> -	int i, len;
> +	unsigned i;
> +	int len;
>  
>  	/*
>  	 * Some backends already add an extra newline, so also provide
> -- 
> 2.1.4
> 
> 
> From 5e88ee334fba3d20f676c2a0d8f3edc6056779b5 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Thu, 13 Oct 2016 16:07:22 +0200
> Subject: [PATCH 2/2] smbd: Fix a comment
> 
> This is described in
> 
> https://msdn.microsoft.com/en-us/library/cc232053.aspx
> 
> which is section 2.3.67 in the FSCC version available 2016-10-13.
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/smbd/smb2_ioctl_filesys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/smbd/smb2_ioctl_filesys.c b/source3/smbd/smb2_ioctl_filesys.c
> index 55ce3f2..f2a0554 100644
> --- a/source3/smbd/smb2_ioctl_filesys.c
> +++ b/source3/smbd/smb2_ioctl_filesys.c
> @@ -187,7 +187,7 @@ static NTSTATUS fsctl_zero_data(TALLOC_CTX *mem_ctx,
>  	}
>  
>  	/*
> -	 * MS-FSCC <58> Section 2.3.65
> +	 * MS-FSCC <58> Section 2.3.67
>  	 * This FSCTL sets the range of bytes to zero (0) without extending the
>  	 * file size.
>  	 *
> -- 
> 2.1.4
>