[PATCH] Remove micro-clone in libcli/security/sddl.c

Simo simo at samba.org
Thu Oct 13 02:38:50 UTC 2016


On Wed, 2016-10-12 at 15:16 -0700, Jeremy Allison wrote:
> On Wed, Oct 12, 2016 at 11:53:39PM +0200, Moritz Beller wrote:
> > 
> > The attached patch fixes a code duplication issue in
> > libcli/security/sddl.c, cf.
> > https://bugzilla.samba.org/show_bug.cgi?id=12373
> > 
> > Best
> > Moritz
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>

LGTM

> Can I get a second Team reviewer ?
> 
> > 
> > From 3b04827287e9e648db30c17251ac9eb88f802fc3 Mon Sep 17 00:00:00
> > 2001
> > From: Moritz Beller <moritzbeller at gmx.de>
> > Date: Tue, 11 Oct 2016 15:39:55 +0200
> > Subject: [PATCH] libcli: Remove code clone
> > 
> > BUG: https://bugzilla.samba.org/show_bug.cgi?id=12373
> > Signed-off-by: Moritz Beller <moritzbeller at gmx.de>
> > ---
> >  libcli/security/sddl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
> > index 47e5934..9a5a250 100644
> > --- a/libcli/security/sddl.c
> > +++ b/libcli/security/sddl.c
> > @@ -529,7 +529,7 @@ static char *sddl_encode_ace(TALLOC_CTX
> > *mem_ctx, const struct security_ace *ace
> >  	if (ace->type == SEC_ACE_TYPE_ACCESS_ALLOWED_OBJECT ||
> >  	    ace->type == SEC_ACE_TYPE_ACCESS_DENIED_OBJECT ||
> >  	    ace->type == SEC_ACE_TYPE_SYSTEM_AUDIT_OBJECT ||
> > -	    ace->type == SEC_ACE_TYPE_SYSTEM_AUDIT_OBJECT) {
> > +	    ace->type == SEC_ACE_TYPE_SYSTEM_ALARM_OBJECT) {
> >  		if (ace->object.object.flags &
> > SEC_ACE_OBJECT_TYPE_PRESENT) {
> >  			sddl_object = GUID_string(
> >  				tmp_ctx, &ace-
> > >object.object.type.type);
> > -- 
> > 2.7.4
> > 
> 
> 




More information about the samba-technical mailing list