PATCH: util-env

Trever L. Adams trever at middleearth.sapphiresunday.org
Wed Oct 12 19:54:33 UTC 2016


On 10/12/2016 01:08 PM, Volker Lendecke wrote:
>
> We prefer
>
> if (data == NULL) {
> 	return NULL;
> }
>
> with braces just for better debuggability and to avoid a "goto fail"
> vulnerability.
>
> Also, don't you have to terminate the env list with a NULL pointer?
>
> Volker
>
Yes. It does. I am sorry. I some how failed to install after compiling
when doing my testing. This patch has been tested.

Trever

-------------- next part --------------
A non-text attachment was scrubbed...
Name: strv.patch
Type: text/x-patch
Size: 1193 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161012/fa432989/strv.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161012/fa432989/signature.sig>


More information about the samba-technical mailing list