PATCH: util-env

Volker Lendecke vl at
Wed Oct 12 19:08:56 UTC 2016

"Trever L. Adams" <trever at> writes:

> On 10/12/2016 08:50 AM, Volker Lendecke wrote:
> +       if (data == NULL) return NULL;

We prefer

if (data == NULL) {
	return NULL;

with braces just for better debuggability and to avoid a "goto fail"

Also, don't you have to terminate the env list with a NULL pointer?


More information about the samba-technical mailing list