[PATCH] samba-tool user add: new options and fix

[Sergey Urushkin]

Hello!
Here are updated patches against samba-master.
Don't know if the test part is correct and sufficient. On my system 
"make test TESTS=samba_tool.user" doesn't succeed even without patches, 
never run it before:). But it's really simple patch, so I think it 
should be OK.

Andrew Bartlett писал 2016-10-12 01:21:
> On Tue, 2015-10-13 at 13:07 +0300, Sergey Urushkin wrote:
>> Hello, Marc!
>> 
>> Marc Muehlfeld писал 2015-10-12 21:49:
>> > Hello Sergey,
>> >
>> > Am 08.10.2015 um 14:16 schrieb Sergey Urushkin:
>> > > This simple patch adds new options to "samba-tool user add"
>> > > command:
>> > >  * middle-name    - allows specifying  middleName
>> > >  * display-name   - allows to manually specify displayName
>> > >
>> > > And Fixes "initials" option. Do not add dot at the end of
>> > > initials
>> > > attribute, like ADUC behaves (only add dot to displayName if not
>> > > specified).
>> >
>> >
>> > Thanks for the patch. Three comments from my side:
>> > * Can you put the "initials fix" into a separate patch?
>> > * Limit the line length to 80 characters
>> > * Please add your Signed-off-by tag
>> >
>> Done. Please, review.
>> >
>> > Regards,
>> > Marc
>> 
>> ---
>> Best regards,
>> Sergey Urushkin
> 
> Sorry for the very long delay looking at this, and thanks to SATOH
> Fumiyasu for reminding us. 
> 
> The patch looks good, and it would be great if we could get a test for
> it.  Sadly in the meantime it has also suffered as other changes now
> cause conflicts, so it needs to be reworked before it can get in.
> 
> Sorry,
> 
> Andrew Bartlett

-- 
Best regards,
Sergey Urushkin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-middle-name-and-display-name-options-to-samba-to.patch
Type: text/x-diff
Size: 10574 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161012/3dd9708b/0001-Add-middle-name-and-display-name-options-to-samba-to.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-samba-tool-user-create-initials-option-only-add-.patch
Type: text/x-diff
Size: 872 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161012/3dd9708b/0002-Fix-samba-tool-user-create-initials-option-only-add-.diff>