[PATCH] samba-tool user add: new options and fix
abartlet at samba.org
Tue Oct 11 22:21:33 UTC 2016
On Tue, 2015-10-13 at 13:07 +0300, Sergey Urushkin wrote:
> Hello, Marc!
> Marc Muehlfeld писал 2015-10-12 21:49:
> > Hello Sergey,
> > Am 08.10.2015 um 14:16 schrieb Sergey Urushkin:
> > > This simple patch adds new options to "samba-tool user add"
> > > command:
> > > * middle-name - allows specifying middleName
> > > * display-name - allows to manually specify displayName
> > >
> > > And Fixes "initials" option. Do not add dot at the end of
> > > initials
> > > attribute, like ADUC behaves (only add dot to displayName if not
> > > specified).
> > Thanks for the patch. Three comments from my side:
> > * Can you put the "initials fix" into a separate patch?
> > * Limit the line length to 80 characters
> > * Please add your Signed-off-by tag
> Done. Please, review.
> > Regards,
> > Marc
> Best regards,
> Sergey Urushkin
Sorry for the very long delay looking at this, and thanks to SATOH
Fumiyasu for reminding us.
The patch looks good, and it would be great if we could get a test for
it. Sadly in the meantime it has also suffered as other changes now
cause conflicts, so it needs to be reworked before it can get in.
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical