smbtorture tests for SMB3 OFFLOAD_READ / OFFLOAD_WRITE?

David Disseldorp ddiss at suse.de
Mon Oct 10 08:04:47 UTC 2016


On Fri, 7 Oct 2016 19:36:07 -0400, Gordon Ross wrote:

> > IIUC, this test is filling the source to 16320 bytes, then attempting to
> > copy 16384 bytes into the 16384 dest file. Is the short-read ignored?
> > Also, I would expect the pattern check to choke on the last (zeroed) 64
> > bytes of the dest file:  
> 
> ODX read is supposed to round up to disk blocks.
> The rounded up range should transfer as zeros.
> This test is exercising that logic.
> 
> > ...  
> > > +     ok = check_pattern(torture, tree, tmp_ctx, dest_h, 0, fsize, 0);
> > > +     if (!ok) {
> > > +             torture_fail(torture, "inconsistent file data");
> > > +     }  

This check_pattern() uses fsize (16384), so if the rounded up area is
zeroed then I would expect this to fail, unless I'm missing something.

Cheers, David



More information about the samba-technical mailing list