[PATCH] restructure messaging

Andrew Bartlett abartlet at samba.org
Mon Oct 10 02:50:17 UTC 2016

On Wed, 2016-10-05 at 16:35 +0200, Volker Lendecke wrote:
> Andrew Bartlett <abartlet at samba.org> writes:
> > On Fri, 2016-09-30 at 08:26 -0700, Volker Lendecke wrote:
> > 
> > Can you add a variation on "Subject: [PATCH 16/30] messaging: add
> > an
> > overflow test" that confirms that all the messages are picked up?
> > 
> Attached find a try.
> Review?
> Thanks, Volker

Thanks.  I get:

../source4/lib/messaging/tests/messaging.c: In function
../source4/lib/messaging/tests/messaging.c:248:3: error: ‘memset’ used
with constant zero length parameter; this could be due to transposed
parameters [-Werror=memset-transposed-args]
   memset(state->final, sizeof(state->final), 0);
cc1: all warnings being treated as errors

I can't see however what final and done are for, or where they are
checked, so I'm not confident on just the simple fix.


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list