[PATCH] Small update for libnet

Jeremy Allison jra at samba.org
Thu Oct 6 16:13:12 UTC 2016


On Thu, Oct 06, 2016 at 05:25:28PM +0200, Andreas Schneider wrote:
> On Thursday, 6 October 2016 16:38:47 CEST Günther Deschner wrote:
> > Hi Andreas,
> 
> Hi Günther,
> 
> > The only remark I would have had for this (now already pushed to master)
> > is that the change will break support for joining older samba DCs (still
> > seen in real life here and there) that did not support all info levels
> > (like 16) on the samr_SetUserInfo2 path but instead only had it
> > available via samr_SetUserInfo. For robustness reasons we might want to
> > try to restore for this later.
> 
> for my defense I would argue that this should have been documented in the 
> code! :-)
> 
> FYI: This is only valid for Samba 3.0, samr_SetUserinfo2 calls 
> samr_SetUserInfo since 3.2.

I'm OK with not supporting Samba 3.0.x DC's anymore :-).



More information about the samba-technical mailing list