[PATCH] restructure messaging - additional comments patch.

Jeremy Allison jra at samba.org
Wed Oct 5 17:55:16 UTC 2016

On Wed, Oct 05, 2016 at 11:43:37AM +0200, Volker Lendecke wrote:
> Stefan Metzmacher <metze at samba.org> writes:
> > I think 2 patches were missing in that push.
> >
> > I'm currently getting panics during the environment teardown.
> > (see out.tevent-segfault01.txt)
> >
> > I think these are the ones Volker already fixed during the
> > flight back.
> >
> > Is it ok to push the attached 3 patches?
> I'm fine with that. I had sent my message with the additional path on
> Sun, 02 Oct 2016 11:17:12. Because this patchset is a bit on the large
> side, I've put it just in a git repo, sorry for that. The additional
> patch does fix the segfault on shutdown for me. I'll push with your
> review and my review of the tevent version bump.

Here is an additional COMMENTS ONLY :-) patchset that I think
might be useful.

It contains the comments I made for myself on the new
code whilst I was reviewing it, and adds them as function

This is *very* tricky code :-), and I'm hoping that this
will make it more accessible to third parties working on

Please review and push if you agree.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-lib-messaging.-Add-function-comments-I-needed-to-.patch
Type: text/x-diff
Size: 8492 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161005/2c0f725b/0001-s3-lib-messaging.-Add-function-comments-I-needed-to-.diff>

More information about the samba-technical mailing list