[samba-team/samba] smb2/ioctl: add support for FSCTL_[GET/SET]_COMPRESSION (4ffc85d)

[David Disseldorp]

Hi Nick,

Please address such questions in future to the samba-technical list in
future...

On Mon, 03 Oct 2016 00:50:17 -0700, Nick Barrett wrote:

> @ddiss & @jrasamba 
> 
> Hi there.
> 
> First off, thanks for the work done here.
> 
> I would like to ask if someone could investigate a problem I have encountered. I have logged the problem I am having here https://bugzilla.samba.org/show_bug.cgi?id=12144
> I believe that when when the file system doesn't support compression, the FSCTL_SET_COMPRESSION case in smb2_ioctl_filesys should return STATUS_INVALID_DEVICE_REQUEST instead of STATUS_NOT_SUPPORTED. I believe the return on line 105 should be changed.

Thanks a lot for your analysis here! I did some testing against Windows
Server 2016 with ReFS and found that Windows in-fact responds
successfully to a get-compression request when the underlying FS doesn't
support it.

Please find a patch attached that attempts to have us match this
behaviour. Testing / feedback appreciated.

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compression-unsupported.patchset
Type: application/octet-stream
Size: 5865 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161004/555ae168/compression-unsupported.obj>