[PATCHES] MS-PAR rpcclient

[Jeremy Allison]

On Wed, Nov 30, 2016 at 07:45:18PM +0100, Andreas Schneider wrote:
> On Wednesday, 30 November 2016 10:22:30 CET Jeremy Allison wrote:
> > On Wed, Nov 30, 2016 at 12:33:25PM -0500, jim wrote:
> > > The integer wrap check is different from the increment - it is
> > > missing '8 +'.
> > 
> > Good catch - thanks ! Updated patch attached.
> > 
> > Jeremy.
> > 
> > > On 11/30/2016 12:29 PM, Jeremy Allison wrote:
> > > >  	/* data */
> > > >  	for (i = 0; i < ndr_count_cfdata(r); i++) {
> > > >
> > > >+		if (size + r->cfdata[i].cbData < size) {
> > > >+			/* Integer wrap. */
> > > >+			return false;
> > > >+		}
> > > >
> > > >  		size += 8 + r->cfdata[i].cbData;
> 
> Still not correct. Patch with my RB+ and squash patch attached.

Thanks. Not having a good day today :-).

Pushed.