[PATCHES] MS-PAR rpcclient

[Andreas Schneider]

On Wednesday, 30 November 2016 10:22:30 CET Jeremy Allison wrote:
> On Wed, Nov 30, 2016 at 12:33:25PM -0500, jim wrote:
> > The integer wrap check is different from the increment - it is
> > missing '8 +'.
> 
> Good catch - thanks ! Updated patch attached.
> 
> Jeremy.
> 
> > On 11/30/2016 12:29 PM, Jeremy Allison wrote:
> > >  	/* data */
> > >  	for (i = 0; i < ndr_count_cfdata(r); i++) {
> > >
> > >+		if (size + r->cfdata[i].cbData < size) {
> > >+			/* Integer wrap. */
> > >+			return false;
> > >+		}
> > >
> > >  		size += 8 + r->cfdata[i].cbData;

Still not correct. Patch with my RB+ and squash patch attached.


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: look
Type: application/mbox
Size: 4028 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161130/4d7b2999/look.mbox>