[PATCH] s3: libsmb: Setting the LIBSMBCLIENT_NO_CCACHE environment variable doesn't turn off credential cache use.

Jeremy Allison jra at samba.org
Wed Nov 30 18:27:35 UTC 2016


On Tue, Nov 29, 2016 at 08:22:57PM -0500, Ira Cooper wrote:
> Shouldn't it be if the environment var is set?
> 
>      if (getenv("LIBSMBCLIENT_NO_CCACHE") == NULL) {
> -        smbc_setOptionUseCCache(context, true);
> +        smbc_setOptionUseCCache(context, false);
>      }
> 
> Shouldn't it be !=?
> 
> Cheers,

Fixed patch attached. Sorry for the screw-up :-(.
(even one-liners can be messed up :-).

Thanks,

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-libsmb-Setting-the-LIBSMBCLIENT_NO_CCACHE-environ.patch
Type: text/x-diff
Size: 1128 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161130/14de865a/0001-s3-libsmb-Setting-the-LIBSMBCLIENT_NO_CCACHE-environ.diff>


More information about the samba-technical mailing list