[PATCH] s3: libsmb: Setting the LIBSMBCLIENT_NO_CCACHE environment variable doesn't turn off credential cache use.

Jeremy Allison jra at samba.org
Wed Nov 30 16:49:42 UTC 2016


On Tue, Nov 29, 2016 at 08:22:57PM -0500, Ira Cooper wrote:
> Shouldn't it be if the environment var is set?
> 
>      if (getenv("LIBSMBCLIENT_NO_CCACHE") == NULL) {
> -        smbc_setOptionUseCCache(context, true);
> +        smbc_setOptionUseCCache(context, false);
>      }
> 
> Shouldn't it be !=?

Doh. This is why reviews are critical. Thanks Ira.

(Hides my head in shame :-).



More information about the samba-technical mailing list