Some patches to compile with gcc-next
Douglas Bagnall
douglas.bagnall at catalyst.net.nz
Wed Nov 30 01:35:29 UTC 2016
On 30/11/16 12:39, Jeremy Allison wrote:
> On Wed, Nov 30, 2016 at 11:13:47AM +1300, Douglas Bagnall wrote:
>>
>> Ah yes. It seems I poorly estimated my available time.
>>
>> This version uses talloc_asprintf() so the size calculations are all
>> hidden away and hopefully correct.
>
> Thanks Douglas,
>
> It's close, but still needs a not-null pointer check after
> the talloc_XXX() calls.
>
> i.e.
>
> if (rname == NULL) {
> error out somehow...
> }
>
> I could fix it for you but I really want to help
> Team members write out-of-the-box good patches
> (sorry).
Fair enough. My feeble excuse is I was following the existing practice
in the source4 smb_client.
Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smbclient-fix-string-formatting-in-print-command.patch
Type: text/x-diff
Size: 1918 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161130/772fcf42/smbclient-fix-string-formatting-in-print-command.diff>
More information about the samba-technical
mailing list