[PATCH] Fix the samba3 dependency hell

[Andreas Schneider]

On Wednesday, 23 November 2016 21:52:21 CET Michael Adam wrote:
> On 2016-11-22 at 17:36 +0100, Andreas Schneider wrote:
> > On Tuesday, 22 November 2016 14:20:00 CET Andreas Schneider wrote:
> > > Hello,
> > > 
> > > last week I sent a patch to fix an issue with newer versions of the gold
> > > linker complaining about our circular dependencies.
> > > 
> > > This patch did not work on Ubuntu. It looks like I produces an issue
> > > with
> > > the Kerberos library. On Ubuntu 14.04 we link against openldap2 libaries
> > > which link against Kerberos libraries. So when we link smbd we link
> > > against
> > > two Kerberos libaries, yay!
> > > 
> > > 
> > > However I needed a different approach to fix the circular dependencies.
> > > Yes, we have two of them:
> > > 
> > > param => smbconf
> > > smbconf => param
> > > 
> > > and
> > > 
> > > smbconf => smbregistry
> > > smbregistry => smbconf
> 
> There are more, just not so simple ones.
> I'll post a patchset that resolves another
> circular dep which I fixed 3 years ago.
> Just found the patch again. ;-)
> 
> > > I've tried to change smbconf first to only consume samba-hostconfig, but
> > > this didn't work. Decoupling param from smbconf is also not possible. So
> > > thinking about this mess there was only one solution.
> > > 
> > > As smbconf is a public library, param a subsystem and smbregistry a
> > > library
> > > the correct thing to do is to push everything in smbconf library.
> > > 
> > > That's what I did. So everything links against smbconf now.
> > > 
> > > 
> > > Please review the attached patchset and push if you're ok.
> > > 
> > > 
> > > 
> > > Thanks,
> > > 
> > > 	Andreas
> > 
> > Updated patchset
> 
> What is the update about? :-)
> (Sure I could diff the patchset files... ;-)
> 
> No final review yet, but a few initial thoughts:
> 
> - Why the 55 reformatting patches?
>   This kind of contradicts the samba guidelines
>   of only reformatting the contexts that we touch
>   with the actual changes.
> 
> - Regarding the actual dependency changes, I would
>   like to think about this a little more, as I was
>   on it some time ago but got distracted. I assume
>   though that your approach is correct at least
>   for the short term.
> 
> - The smaller dep-change patches are definitely ok.
> 
> Will follow up ...

Ping!


I think we need to backport the patches to 4.5 and 4.4. See

https://bugzilla.samba.org/show_bug.cgi?id=12450



	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org