[PATCH] Make more PIDL-generated tables static const
jra at samba.org
Mon Nov 28 18:20:43 UTC 2016
On Tue, Nov 29, 2016 at 07:15:46AM +1300, Andrew Bartlett wrote:
> On Mon, 2016-11-28 at 10:23 +0100, Andreas Schneider wrote:
> > On Monday, 28 November 2016 16:55:13 CET Andrew Bartlett wrote:
> > >
> > > On Mon, 2016-11-21 at 17:04 +1300, Andrew Bartlett wrote:
> > > >
> > > > While working on the previous patches, I noticed some function
> > > > tables
> > > > generated by PIDL are not static const. This patches makes them
> > > > static
> > > > and or const, which moves them to single-file scope read-only
> > > > memory.
> > > >
> > > > Please comment and push if OK.
> > >
> > > Can I please get a review on these?
> > The patches look good, but:
> > git am3 ~/Downloads/p/0020-s4-rpc_server-Avoid-extern-reference-to-
> > dcesrv_mgmt_.patch
> > Applying: s4-rpc_server: Avoid extern reference to
> > dcesrv_mgmt_interface and
> > memcpy()
> > fatal: sha1 information is lacking or useless (source4/rpc_server/
> > dcerpc_server.c).
> > error: could not build fake ancestor
> > Patch failed at 0001 s4-rpc_server: Avoid extern reference to
> > dcesrv_mgmt_interface and memcpy()
> > The copy of the patch that failed is found in: .git/rebase-
> > apply/patch
> > When you have resolved this problem, run "git am --continue".
> > If you prefer to skip this patch, run "git am --skip" instead.
> > To restore the original branch and stop patching, run "git am --
> > abort".
> > Please rebase on master and push yourself. RB+
> Thanks. These are as you have probably seen a part of my larger multi-
> process patch set I re-sent to the list yesterday. I'll get them
> separated or also get reviewed what it depends on.
Wow, lots to do after coming back on vacation :-).
I'm planning to review the talloc changes as a separate
patchset - all talloc changes should be able to stand
As for the other code - one minor request, can you
change to use the DBG_XXX() macros in new code, as
I'm hoping to eventually be able to get rid of the
More information about the samba-technical