[PATCH] Make more PIDL-generated tables static const
asn at samba.org
Mon Nov 28 09:23:58 UTC 2016
On Monday, 28 November 2016 16:55:13 CET Andrew Bartlett wrote:
> On Mon, 2016-11-21 at 17:04 +1300, Andrew Bartlett wrote:
> > While working on the previous patches, I noticed some function tables
> > generated by PIDL are not static const. This patches makes them
> > static
> > and or const, which moves them to single-file scope read-only
> > memory.
> > Please comment and push if OK.
> Can I please get a review on these?
The patches look good, but:
git am3 ~/Downloads/p/0020-s4-rpc_server-Avoid-extern-reference-to-
Applying: s4-rpc_server: Avoid extern reference to dcesrv_mgmt_interface and
fatal: sha1 information is lacking or useless (source4/rpc_server/
error: could not build fake ancestor
Patch failed at 0001 s4-rpc_server: Avoid extern reference to
dcesrv_mgmt_interface and memcpy()
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Please rebase on master and push yourself. RB+
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical