[PATCH] remove ntlm_auth4
vl at samba.org
Fri Nov 25 09:45:55 UTC 2016
On Fri, Nov 25, 2016 at 08:36:38PM +1300, Andrew Bartlett wrote:
> On Fri, 2016-11-25 at 07:23 +0100, Volker Lendecke wrote:
> > On Fri, Nov 25, 2016 at 02:05:29PM +1300, Andrew Bartlett wrote:
> > >
> > > On Thu, 2016-11-24 at 19:38 +0100, Volker Lendecke wrote:
> > >
> > > >
> > > > Ok, if the way ntlm_auth works is set in stone I formally request
> > > > to
> > > > drop my patch and keep both around. I'll start looking around for
> > > > alternatives.
> > >
> > > Would you please care to elaborate?
> > It's the old argument between API and protocol. ntlm_auth is designed
> > to call gensec directly, my plan would have been to change that. We
> > know how this argument went for pdb and auth and how it will end for
> > ntlm_auth.
> I have to say I'm now rather confused: Are we discussing patches to
> remove ntlm_auth4 or some unpublished patch series to restructure
> ntlm_auth in some way?
This patch was the start of me looking at re-working ntlm_auth3 such
that more logic is happening in winbind. While there my usual approach
is to also look left and right trying to understand the environment.
One thing that annoyed me was that with emacs tags I always ended up
in the source4 version of ntlm_auth. So I asked myself whether that is
still required at all and ended up with the patch proposal.
As re-working ntlm_auth3 is now cancelled due to the architectural
approach, the ntlm_auth4 removal patch is no longer on my list.
More information about the samba-technical