[PATCH] Remove x_file from ntlm_auth and ntlm_auth4 (was: Re: [PATCH] some cleanups)

Andrew Bartlett abartlet at samba.org
Fri Nov 25 01:22:06 UTC 2016

On Thu, 2016-11-24 at 20:45 +0100, Volker Lendecke wrote:
> Hi!
> Review appreciated!

G'Day Volker,

Could you please use a relevant subject, like [PATCH] Remove x_file
from ntlm_auth and ntlm_auth4?

It is really hard to follow which clean-ups are which, and it is a
large code-base.  Most of your work is great, but it is frustrating to
need to open the patch to work out what it is on.

As to x_file, xfile.c mentions:

  stdio is very convenient, but on some systems the file descriptor
  in FILE* is 8 bits, so it fails when more than 255 files are open. 

The history (from memory) was that the 'some systems' referenced some
ancient solaris.  Thankfully it looks like this is long-gone, for
Solaris 10 and later:



Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list