[PATCHES] MS-PAR rpcclient

Andreas Schneider asn at samba.org
Thu Nov 24 07:48:04 UTC 2016


On Wednesday, 23 November 2016 16:26:17 CET Günther Deschner wrote:
> On 23/11/16 16:14, Andreas Schneider wrote:
> > On Wednesday, 23 November 2016 16:04:47 CET Günther Deschner wrote:
> >> Hi,
> >> 
> >> attached some patches to create a basic iremotewinspool rpcclient tool.
> >> 
> >> Note that the object_uuid is set directly in the
> >> dcerpc_binding_handle_call() unlike our smbtorture4 client
> >> iremotewinspool code where we set the interface specific object_uuid via
> >> the binding handle (passing down the full binding in s3 rpc_client code
> >> would require some major restructuring which we would like to avoid for
> >> now).
> > 
> > a) We have 2016, see copyright :)
> 
> Yeah but the code was in fact written in 2013.
> 
> > b) Instead of Async* I would prefered if calls would start with winspool
> > instead. This make it clear we use the winspool protocol here. We have tab
> > completion in rpcclient and this would make it easier to find a winspool
> > comand.
> 
> Done, I added a winspool_ prefix now. Better?
> 
> Thanks,
> Guenther


Pushed to autobuild

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list