[PATCH] net conf: add parameter value check to 'net conf setparm'
slow at samba.org
Wed Nov 23 11:54:37 UTC 2016
On Wed, Nov 23, 2016 at 12:52:13PM +0100, Michael Adam wrote:
> On 2016-11-23 at 12:24 +0100, Ralph Böhme wrote:
> > Howdy,
> > On Wed, Nov 23, 2016 at 12:15:12PM +0100, Ralph Böhme wrote:
> > > > this could be combined with your patchset so as to avoid doing the
> > > > back and forth business. Attached second patchset demonstrates how
> > > > this could look like.
> > >
> > > Looking into this one...
> > code lgtm, but I'd like to see an update of the function comment as
> > part of the last commit as well please. :)
> > With an updated comment: rb:me.
> Did an update.
> Updated patchset attached.
> Added your review except for the last patch with the comment.
> Also kept Volker's review for the first patch which was not
> changed at all.
More information about the samba-technical