[PATCH] net conf: add parameter value check to 'net conf setparm'

Ralph Böhme slow at samba.org
Wed Nov 23 11:15:12 UTC 2016

Hi Michael,

On Wed, Nov 23, 2016 at 11:41:35AM +0100, Michael Adam wrote:
> good catch and nice patches, thank you!
> Only thought I had was this:
> wouldn't it be natural to put the call to
> lp_parameter_value_is_valid()
> into lp_canonicalize_parameter_with_value()
> which is already doing some value sanitation?
> This is also called from smbconf_reg_set_value(),
> so that other clients than "net conf" would
> also benefit from the change.
> See the attached add-on patchset.
> Since your patch has not landed yet, ...

*phew* That was a close thing. Cancelled my autobuild.

> this could be combined with your patchset so as to avoid doing the
> back and forth business.  Attached second patchset demonstrates how
> this could look like.

Looking into this one...


More information about the samba-technical mailing list