[PATCH] fix smb signing in connect_to_service() for non-ipc$ shares in net

Ralph Böhme slow at samba.org
Wed Nov 23 04:29:56 UTC 2016


On Wed, Nov 23, 2016 at 12:49:23AM +0100, Günther Deschner wrote:
> smb signing fails for non-ipc$ shares in the 'net' helper call. Noticed
> while working on new core printer driver migration utility.

I haven't looked closely, but iirc we need something like this

        if (strequal(service_type, "IPC")) {
                signing_setting = SMB_SIGNING_IPC_DEFAULT;

        if (signing_setting == SMB_SIGNING_IPC_DEFAULT) {
                 * Ensure for IPC/RPC the default is to require                                                                                                                                          
                 * signing unless explicitly turned off by the                                                                                                                                           
                 * administrator.                                                                                                                                                                        
                signing_setting = lp_client_ipc_signing();                                                                                                                                                 

        if (signing_setting == SMB_SIGNING_DEFAULT) {                                                                                                                                                      
                signing_setting = lp_client_signing();                                                                                                                                                     

cf source3/libsmb/clientgen.c


More information about the samba-technical mailing list