[PATCH] Fix the samba3 dependency hell

Andreas Schneider asn at samba.org
Tue Nov 22 16:36:37 UTC 2016


On Tuesday, 22 November 2016 14:20:00 CET Andreas Schneider wrote:
> Hello,
> 
> last week I sent a patch to fix an issue with newer versions of the gold
> linker complaining about our circular dependencies.
> 
> This patch did not work on Ubuntu. It looks like I produces an issue with
> the Kerberos library. On Ubuntu 14.04 we link against openldap2 libaries
> which link against Kerberos libraries. So when we link smbd we link against
> two Kerberos libaries, yay!
> 
> 
> However I needed a different approach to fix the circular dependencies. Yes,
> we have two of them:
> 
> param => smbconf
> smbconf => param
> 
> and
> 
> smbconf => smbregistry
> smbregistry => smbconf
> 
> 
> I've tried to change smbconf first to only consume samba-hostconfig, but
> this didn't work. Decoupling param from smbconf is also not possible. So
> thinking about this mess there was only one solution.
> 
> As smbconf is a public library, param a subsystem and smbregistry a library
> the correct thing to do is to push everything in smbconf library.
> 
> That's what I did. So everything links against smbconf now.
> 
> 
> Please review the attached patchset and push if you're ok.
> 
> 
> 
> Thanks,
> 
> 
> 
> 	Andreas


Updated patchset


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: master_param_smbconf_smbregistry-v2.patch
Type: text/x-patch
Size: 115379 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161122/1809282d/master_param_smbconf_smbregistry-v2-0001.bin>


More information about the samba-technical mailing list