[PATCH] VFS: convert to using ceph_statx structures and functions, when available
jlayton at samba.org
Fri Nov 18 12:09:20 UTC 2016
On Thu, 2016-11-17 at 22:39 +0100, Ralph Böhme wrote:
> On Thu, Nov 17, 2016 at 01:13:57PM -0500, Jeff Layton wrote:
> > Add a configure test for the ceph_statx function, and use that to
> > determine whether to compile in new functions that use it and its
> > variants, or whether to use a the older code that fetches birthtimes
> > from an xattr.
> > For cephwrap_lstat, we can use ceph_statx with the AT_SYMLINK_NOFOLLOW
> > flag to get the right lookup semantics.
> > For setting the times via cephwrap_ntimes, We can just use ceph_setattrx
> > and pass them all in at the same time.
> fwiw, this is something that I've been working on lately: add a full
> fledged VFS_STATX call to out VFS.
> The primary reason and benefit is performance, as it helps avoiding
> reduntant stuff in the VFS frontend->backend interaction.
> It'll also allow fetching *all* relevant file metadata attributes in a
> VFS_STATX call, like btime or windows attributes, so it will be a nice
> cleanup as well.
> This is not ready and still work in progress, but seeing Jeff's work
> on statx patches for ceph I thought I wanted to show what I have right
Great! I was going to spin up some statx patches for samba and nfs-
ganesha once I wrapped up the ceph work. My hope is that if we have some
applications that are eager to use these new interfaces, it'll help make
the case to get it merged into Linux.
Since you seem to have the samba side in hand, I'll let you run with it
and will focus on getting nfs-ganesha fixed up.
Jeff Layton <jlayton at samba.org>
More information about the samba-technical