[PATCH] Add support for APD_COPY_FROM_DIRECTORY in AddPrinterDriverEx()

Andreas Schneider asn at samba.org
Fri Nov 18 09:54:13 UTC 2016

On Thursday, 17 November 2016 15:30:11 CET Jeremy Allison wrote:
> On Thu, Nov 17, 2016 at 09:04:13AM +0100, Andreas Schneider wrote:
> > See attached patch :)
> Thanks - much better.
> But for new code I think we should check for talloc fails,
> even in torture code. The new code in test_driver_copy_from_directory()
> does a lot of unchecked CREATE_PRINTER_DRIVER_PATH() and
> talloc_zero calls.
> Can we fix that please (a simple 'goto fail' should do).

Yes, sure. Patch attached.

Please review and push with the other spoolss patches.



Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spoolss_copy_from_directory_v42.patch
Type: text/x-patch
Size: 21429 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161118/6bf2858c/spoolss_copy_from_directory_v42.bin>

More information about the samba-technical mailing list