[PATCH] Fix bug 12419 - AD access check function isn't IPv6-aware.

Andreas Schneider asn at samba.org
Wed Nov 16 11:04:56 UTC 2016


On Wednesday, 16 November 2016 20:05:08 CET Amitay Isaacs wrote:
> On Wed, Nov 16, 2016 at 6:58 PM, Martin Schwenke <martin at meltin.net> wrote:
> > On Wed, 16 Nov 2016 08:43:45 +0100, Andreas Schneider <asn at samba.org>
> > 
> > wrote:
> > > On Wednesday, 16 November 2016 08:16:44 CET Andreas Schneider wrote:
> > > > On Tuesday, 15 November 2016 08:59:35 CET Jeremy Allison wrote:
> > > > > As described in $SUBJECT. Removes the non-IPv6 aware source4/
> > > > > access_check() function by moving the IPv6-aware version from
> > > > > source3/ to the top level and using one common function across
> > > > > all the code. More merged code (yay !).
> > > > > 
> > > > > Tested and confirmed working by the original reporter
> > > > > Heath Kehoe <heath at digitalartefacts.com>.
> > > > > 
> > > > > Please review and push if happy !
> > > > > 
> > > > > Cheers,
> > > > > 
> > > > >   Jeremy.
> > > > 
> > > > LGTM - Pushed to autobuild.
> > > > 
> > > > 
> > > > For master could you please document allow_access() and
> > 
> > allow_access_nolog()
> > 
> > > > with Doxygen comments?
> > > 
> > > While you're at it. The ctdb build fails with your patchset:
> > > 
> > > cd ctdb
> > > ./configure
> > > make -j
> > > WAF_MAKE=1 PATH=buildtools/bin:../buildtools/bin:$PATH waf build
> > > Waf: Entering directory `/home/asn/workspace/projects/samba/ctdb/bin'
> > > Checking project rules ...
> > > Unknown dependency 'interfaces' in 'access'
> > > 
> > > 
> > > Please fix :)
> > 
> > In lib/util/wscript_build, it will need to be in the else part of this:
> > 
> > if bld.env.SAMBA_UTIL_CORE_ONLY:
> >   ...
> > 
> > else:
> >   ...
> > 
> > Sorry, it is gross.  We really need to do more clean-up and properly
> > separate out a subset of lib/util/ into a subdirectory.  The
> > underlying problem here is that some things in lib/util/ drag in things
> > from source3/ (and source4/?), and for CTDB we don't want to go down
> > that rat hole...
> 
> Even though there is a comment on top of lib/util/wscript_build, it's not
> prominent enough. :-)
> 
> Here's the fixup for patch 08/10.
> 
> Amitay.

Looks good, pushed to autobuild again.

Thanks!

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list